[ 
https://issues.apache.org/jira/browse/BEAM-4594?focusedWorklogId=118450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118450
 ]

ASF GitHub Bot logged work on BEAM-4594:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jul/18 22:23
            Start Date: 02/Jul/18 22:23
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request 
#5691: [BEAM-4594] Beam Python state and timers user-facing API
URL: https://github.com/apache/beam/pull/5691#discussion_r199606354
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/core.py
 ##########
 @@ -288,13 +329,21 @@ class DoFn(WithTypeHints, HasDisplayData, 
urns.RunnerApiFn):
   callable object using the CallableWrapperDoFn class.
   """
 
-  ElementParam = 'ElementParam'
-  SideInputParam = 'SideInputParam'
-  TimestampParam = 'TimestampParam'
-  WindowParam = 'WindowParam'
-  WatermarkReporterParam = 'WatermarkReporterParam'
-
-  DoFnParams = [ElementParam, SideInputParam, TimestampParam, WindowParam]
+  # Parameters that can be used in the .process() method.
+  ElementParam = _BuiltinDoFnParam('ElementParam')
+  SideInputParam = _BuiltinDoFnParam('SideInputParam')
+  TimestampParam = _BuiltinDoFnParam('TimestampParam')
+  WindowParam = _BuiltinDoFnParam('WindowParam')
+  WatermarkReporterParam = _BuiltinDoFnParam('WatermarkReporterParam')
+
+  DoFnProcessParams = [ElementParam, SideInputParam, TimestampParam,
+                       WindowParam, WatermarkReporterParam]
+
+  # Parameters to access state and timers.  Not restricted to use only in the
+  # .process() method. Usage: DoFn.StateParam(state_spec),
+  # DoFn.TimerParam(timer_spec).
+  StateParam = _StateDoFnParam
 
 Review comment:
   Acknowledged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 118450)
    Time Spent: 3h  (was: 2h 50m)

> Implement Beam Python User State and Timer API
> ----------------------------------------------
>
>                 Key: BEAM-4594
>                 URL: https://issues.apache.org/jira/browse/BEAM-4594
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Charles Chen
>            Assignee: Charles Chen
>            Priority: Major
>              Labels: portability
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> This issue tracks the implementation of the Beam Python User State and Timer 
> API, described here: [https://s.apache.org/beam-python-user-state-and-timers].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to