[
https://issues.apache.org/jira/browse/BEAM-4007?focusedWorklogId=118515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118515
]
ASF GitHub Bot logged work on BEAM-4007:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 00:51
Start Date: 03/Jul/18 00:51
Worklog Time Spent: 10m
Work Description: charlesccychen closed pull request #5872: [BEAM-4007]
Fix TODO style in typehints.py
URL: https://github.com/apache/beam/pull/5872
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/typehints/typehints.py
b/sdks/python/apache_beam/typehints/typehints.py
index 5da65fa352d..eb9254a5e6c 100644
--- a/sdks/python/apache_beam/typehints/typehints.py
+++ b/sdks/python/apache_beam/typehints/typehints.py
@@ -416,7 +416,7 @@ def __repr__(self):
return 'Any'
def __hash__(self):
- # TODO(BEAM - 3730)
+ # TODO(BEAM-3730): Fix typehints.TypeVariable issues with __hash__.
return hash(id(self))
def type_check(self, instance):
@@ -432,7 +432,7 @@ def __eq__(self, other):
return type(self) == type(other) and self.name == other.name
def __hash__(self):
- # TODO(BEAM - 3730)
+ # TODO(BEAM-3730): Fix typehints.TypeVariable issues with __hash__.
return hash(id(self))
def __repr__(self):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118515)
Time Spent: 4h 50m (was: 4h 40m)
> Futurize and fix python 2 compatibility for typehints subpackage
> ----------------------------------------------------------------
>
> Key: BEAM-4007
> URL: https://issues.apache.org/jira/browse/BEAM-4007
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
