[
https://issues.apache.org/jira/browse/BEAM-1251?focusedWorklogId=119054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-119054
]
ASF GitHub Bot logged work on BEAM-1251:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/18 11:37
Start Date: 04/Jul/18 11:37
Worklog Time Spent: 10m
Work Description: cclauss opened a new pull request #5887: [BEAM-1251]
Upgrade from buffer to memoryview (again)
URL: https://github.com/apache/beam/pull/5887
This PR is a second shot at #4820 based on [the
work](https://github.com/andrix/python-snappy/pull/72#) that @pitrou has done
to allow python-snappy to support Python memoryviews. This has in turn has
enabled @martindurant to [release python-snappy 0.5.2 to
PyPI](https://pypi.org/project/python-snappy/).
This PR recommends the use of that release to upgrade from buffer to
memoryview in avroio.py because buffer was removed in Python 3 in favor of
memoryview which is supported in a Python versions that Beam supports.
Reviews please from @aaltay @holdenk @superbobry
flake8 testing of https://github.com/apache/beam on Python 3.6.3
$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source
--statistics__
```
./sdks/python/apache_beam/io/avroio.py:343:34: F821 undefined name 'buffer'
result = snappy.decompress(buffer(data)[:-4])
^
1 F821 undefined name 'buffer'
1
```
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 119054)
Time Spent: 11h 40m (was: 11.5h)
> Python 3 Support
> ----------------
>
> Key: BEAM-1251
> URL: https://issues.apache.org/jira/browse/BEAM-1251
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Eyad Sibai
> Assignee: Robbe
> Priority: Trivial
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
> I have been trying to use google datalab with python3. As I see there are
> several packages that does not support python3 yet which google datalab
> depends on. This is one of them.
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/6
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
