[
https://issues.apache.org/jira/browse/BEAM-4671?focusedWorklogId=119823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-119823
]
ASF GitHub Bot logged work on BEAM-4671:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/18 12:47
Start Date: 06/Jul/18 12:47
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #5832: [BEAM-4671] Skip
MetricsPusherTest validates runner test for runners that do not support it yet
URL: https://github.com/apache/beam/pull/5832
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/apex/build.gradle b/runners/apex/build.gradle
index 26d30ee16a2..d51defc6fd1 100644
--- a/runners/apex/build.gradle
+++ b/runners/apex/build.gradle
@@ -97,6 +97,7 @@ task validatesRunnerBatch(type: Test) {
excludeCategories 'org.apache.beam.sdk.testing.UsesSplittableParDo'
excludeCategories 'org.apache.beam.sdk.testing.UsesTestStream'
excludeCategories 'org.apache.beam.sdk.testing.UsesTimersInParDo'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesMetricsPusher'
}
}
diff --git
a/runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MetricsPusherTest.java
b/runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MetricsPusherTest.java
index b588fdcf0f7..4d9fc993554 100644
---
a/runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MetricsPusherTest.java
+++
b/runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MetricsPusherTest.java
@@ -28,6 +28,7 @@
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.testing.UsesAttemptedMetrics;
import org.apache.beam.sdk.testing.UsesCounterMetrics;
+import org.apache.beam.sdk.testing.UsesMetricsPusher;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.transforms.ParDo;
@@ -42,6 +43,7 @@
import org.slf4j.LoggerFactory;
/** A test that verifies that metrics push system works. */
+@Category({UsesMetricsPusher.class})
@RunWith(JUnit4.class)
public class MetricsPusherTest {
private static final Logger LOG =
LoggerFactory.getLogger(MetricsPusherTest.class);
diff --git a/runners/direct-java/build.gradle b/runners/direct-java/build.gradle
index 076a3fe8cb9..35163bcce35 100644
--- a/runners/direct-java/build.gradle
+++ b/runners/direct-java/build.gradle
@@ -130,6 +130,7 @@ task validatesRunner(type: Test) {
useJUnit {
includeCategories "org.apache.beam.sdk.testing.ValidatesRunner"
excludeCategories "org.apache.beam.sdk.testing.LargeKeys\$Above100MB"
+ excludeCategories 'org.apache.beam.sdk.testing.UsesMetricsPusher'
}
}
diff --git a/runners/gearpump/build.gradle b/runners/gearpump/build.gradle
index a14c1f64c9f..c9e644cb622 100644
--- a/runners/gearpump/build.gradle
+++ b/runners/gearpump/build.gradle
@@ -81,6 +81,7 @@ task validatesRunnerStreaming(type: Test) {
excludeCategories 'org.apache.beam.sdk.testing.UsesCustomWindowMerging'
excludeCategories 'org.apache.beam.sdk.testing.UsesParDoLifecycle'
excludeCategories 'org.apache.beam.sdk.testing.UsesImpulse'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesMetricsPusher'
}
}
diff --git a/runners/google-cloud-dataflow-java/build.gradle
b/runners/google-cloud-dataflow-java/build.gradle
index aa3714405cf..b51ded3ef46 100644
--- a/runners/google-cloud-dataflow-java/build.gradle
+++ b/runners/google-cloud-dataflow-java/build.gradle
@@ -127,6 +127,7 @@ task validatesRunnerTest(type: Test) {
excludeCategories 'org.apache.beam.sdk.testing.UsesUnboundedPCollections'
excludeCategories 'org.apache.beam.sdk.testing.UsesTestStream'
excludeCategories 'org.apache.beam.sdk.testing.UsesParDoLifecycle'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesMetricsPusher'
}
}
diff --git a/runners/samza/build.gradle b/runners/samza/build.gradle
index b1a87f995b9..f1bb43ae2ac 100644
--- a/runners/samza/build.gradle
+++ b/runners/samza/build.gradle
@@ -86,6 +86,7 @@ task validatesRunner(type: Test) {
excludeCategories 'org.apache.beam.sdk.testing.UsesSplittableParDo'
excludeCategories 'org.apache.beam.sdk.testing.UsesTestStream'
excludeCategories 'org.apache.beam.sdk.testing.UsesTimersInParDo'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesMetricsPusher'
}
}
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/UsesMetricsPusher.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/UsesMetricsPusher.java
new file mode 100644
index 00000000000..aaa457ab8bb
--- /dev/null
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/UsesMetricsPusher.java
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.testing;
+
+/** Category tag for validation tests which utilize the metrics pusher
feature. */
+public interface UsesMetricsPusher {}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 119823)
Time Spent: 2h 10m (was: 2h)
> skip MetricsPusherTest validates runner test for runners that do not support
> it yet
> ------------------------------------------------------------------------------------
>
> Key: BEAM-4671
> URL: https://issues.apache.org/jira/browse/BEAM-4671
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> For now only Flink and Spark support MetricsPusher. To avoid validates runner
> tests failures, we need to skip MetricsPusherTest for all the other runners.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
