[ https://issues.apache.org/jira/browse/BEAM-4726?focusedWorklogId=119983&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-119983 ]
ASF GitHub Bot logged work on BEAM-4726: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Jul/18 18:54 Start Date: 06/Jul/18 18:54 Worklog Time Spent: 10m Work Description: lostluck commented on a change in pull request #5882: [BEAM-4726] Cache fixed per function Invoke values URL: https://github.com/apache/beam/pull/5882#discussion_r200741621 ########## File path: sdks/go/pkg/beam/core/runtime/exec/fn.go ########## @@ -125,10 +125,148 @@ func Invoke(ctx context.Context, ws []typex.Window, ts typex.EventTime, fn *func return nil, nil } +// InvokeWithoutEventTime runs the given function at time 0 in the global window. func InvokeWithoutEventTime(ctx context.Context, fn *funcx.Fn, opt *MainInput, extra ...interface{}) (*FullValue, error) { return Invoke(ctx, window.SingleGlobalWindow, mtime.ZeroTimestamp, fn, opt, extra...) } +// invoker is a container class for hot path invocations of DoFns, to avoid Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 119983) Time Spent: 3h (was: 2h 50m) > Reduce ParDo per element Invoke overhead > ---------------------------------------- > > Key: BEAM-4726 > URL: https://issues.apache.org/jira/browse/BEAM-4726 > Project: Beam > Issue Type: Sub-task > Components: sdk-go > Reporter: Robert Burke > Assignee: Robert Burke > Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > Each call to invoke allocates a new args []interface{}, but the common case > is to run the same ProcessElement function over and again. It should be > possible to have a container struct to retain the args slice, and avoid > recomputing the indices for where to assign parameters before calling the > ProcessElementFn. -- This message was sent by Atlassian JIRA (v7.6.3#76005)