[
https://issues.apache.org/jira/browse/BEAM-4644?focusedWorklogId=120170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120170
]
ASF GitHub Bot logged work on BEAM-4644:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/18 00:22
Start Date: 07/Jul/18 00:22
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5896: [BEAM-4644] Use
SLF4J in ExecutableStageDoFnOperator
URL: https://github.com/apache/beam/pull/5896
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
index fbd10edae1e..b24c7aa593a 100644
---
a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
+++
b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
@@ -23,7 +23,6 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import java.util.logging.Logger;
import javax.annotation.concurrent.GuardedBy;
import org.apache.beam.model.pipeline.v1.RunnerApi;
import org.apache.beam.runners.core.DoFnRunner;
@@ -47,6 +46,8 @@
import org.apache.beam.sdk.values.TupleTag;
import org.apache.beam.sdk.values.WindowingStrategy;
import org.joda.time.Instant;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* ExecutableStageDoFnOperator basic functional implementation without side
inputs and user state.
@@ -61,7 +62,7 @@
public class ExecutableStageDoFnOperator<InputT, OutputT> extends
DoFnOperator<InputT, OutputT> {
private static final Logger logger =
- Logger.getLogger(ExecutableStageDoFnOperator.class.getName());
+ LoggerFactory.getLogger(ExecutableStageDoFnOperator.class.getName());
private final RunnerApi.ExecutableStagePayload payload;
private final JobInfo jobInfo;
@@ -146,7 +147,7 @@ private void
processElementWithSdkHarness(WindowedValue<InputT> element) throws
try (RemoteBundle<InputT> bundle =
stageBundleFactory.getBundle(
new ReceiverFactory(outputManager, outputMap),
stateRequestHandler, progressHandler)) {
- logger.finer(String.format("Sending value: %s", element));
+ logger.debug(String.format("Sending value: %s", element));
bundle.getInputReceiver().accept(element);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 120170)
Time Spent: 20m (was: 10m)
> ExecutableStageDoFnOperator.java uses JUL instead of SLF4J
> ----------------------------------------------------------
>
> Key: BEAM-4644
> URL: https://issues.apache.org/jira/browse/BEAM-4644
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Rafael Fernandez
> Assignee: Ankur Goenka
> Priority: Minor
> Labels: easy-fix
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Please see discussion on
> [https://lists.apache.org/thread.html/ae293f61424589ade7f0a40665900e234dfca8926150f579790bac09@%3Cdev.beam.apache.org%3E]
> for details.
>
> If this is an intentional choice, please resolve and comment it on the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
