[
https://issues.apache.org/jira/browse/BEAM-3959?focusedWorklogId=120576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120576
]
ASF GitHub Bot logged work on BEAM-3959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/18 05:42
Start Date: 09/Jul/18 05:42
Worklog Time Spent: 10m
Work Description: cclauss opened a new pull request #5901: [BEAM-3959]
Add Python 3 undefined names to flake8
URL: https://github.com/apache/beam/pull/5901
As soon as #5843 and #5900 are closed, we should add F821 (undefined names)
tests to the flake8 tests on Python 3. This should flag commits that contain
unqualified past.builtin imports such as basestring, cmp, raw_input, reload,
unicode, xrange, etc.
**Please** add a meaningful description for your change here
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 120576)
Time Spent: 10m
Remaining Estimate: 0h (was: 2m)
> Eliminating Python "undefined names"
> ------------------------------------
>
> Key: BEAM-3959
> URL: https://issues.apache.org/jira/browse/BEAM-3959
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, sdk-py-harness
> Reporter: cclauss
> Priority: Minor
> Original Estimate: 2m
> Time Spent: 10m
> Remaining Estimate: 0h
>
> My sense is that E901,E999,F821,F822,F823 are the "showstopper" flake8 issues
> that can halt the runtime with a SyntaxError, NameError, etc. The other
> flake8 issues are merely "style violations" -- useful for readability but
> they do not effect runtime safety.
> Work done under https://issues.apache.org/jira/browse/BEAM-3738 has enabled
> Jenkins to run linters on Python 3 code. One of the advantages of the
> *flake8* linter is that it can detect "undefined names" in Python code so it
> has been added to the [Python
> 2|https://github.com/apache/beam/tree/master/sdks/python/run_pylint.sh] and
> [Python
> 3|https://github.com/apache/beam/tree/master/sdks/python/run_mini_py3lint.sh]
> test runs.
> https://github.com/apache/beam/pull/4798 currently lists 23 undefined names
> when flake8 is run under Python 3. Solutions to some of these undefined
> names can be found in:
> * https://github.com/apache/beam/pull/4561
> * https://github.com/apache/beam/pull/4774
> * https://github.com/apache/beam/pull/4820
> Once the Beam codebase can pass a flake8 F821 test with no undefined names,
> then F821 should be added to the the other "showstopper" issues as described
> in https://github.com/apache/beam/pull/4798
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
