[
https://issues.apache.org/jira/browse/BEAM-3310?focusedWorklogId=120669&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120669
]
ASF GitHub Bot logged work on BEAM-3310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/18 08:30
Start Date: 09/Jul/18 08:30
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #4548:
[BEAM-3310] Metrics pusher
URL: https://github.com/apache/beam/pull/4548#discussion_r200338718
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
##########
@@ -120,7 +121,9 @@ public PipelineResult run(Pipeline pipeline) {
if (result instanceof DetachedEnvironment.DetachedJobExecutionResult) {
LOG.info("Pipeline submitted in Detached mode");
- return new FlinkDetachedRunnerResult();
+ FlinkDetachedRunnerResult flinkDetachedRunnerResult = new
FlinkDetachedRunnerResult();
+ // no metricsPusher because metrics are not supported in detached mode
Review comment:
@zorro786 I checked and I'm afraid but supporting metrics pusher in detached
mode does not seem to be possible without a modification of the upstream flink.
Indeed, in this mode even flink accumulators are not available so we will have
no access to the metrics at all, it is not just a matter of terminating the
pusher thread or avoiding the thread (with DAG modification) as I first
thought. To help you understand the architecture, here is a diagram (that is
part of my upcoming presentation at the apacheCon)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 120669)
Time Spent: 14h 50m (was: 14h 40m)
> Push metrics to a backend in an runner agnostic way
> ---------------------------------------------------
>
> Key: BEAM-3310
> URL: https://issues.apache.org/jira/browse/BEAM-3310
> Project: Beam
> Issue Type: New Feature
> Components: runner-extensions-metrics, sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The idea is to avoid relying on the runners to provide access to the metrics
> (either at the end of the pipeline or while it runs) because they don't have
> all the same capabilities towards metrics (e.g. spark runner configures sinks
> like csv, graphite or in memory sinks using the spark engine conf). The
> target is to push the metrics in the common runner code so that no matter the
> chosen runner, a user can get his metrics out of beam.
> Here is the link to the discussion thread on the dev ML:
> https://lists.apache.org/thread.html/01a80d62f2df6b84bfa41f05e15fda900178f882877c294fed8be91e@%3Cdev.beam.apache.org%3E
> And the design doc:
> https://s.apache.org/runner_independent_metrics_extraction
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
