[
https://issues.apache.org/jira/browse/BEAM-4751?focusedWorklogId=121700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121700
]
ASF GitHub Bot logged work on BEAM-4751:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/18 23:42
Start Date: 10/Jul/18 23:42
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5916: [BEAM-4751] fix missing pylint3 check for io subpackage
URL: https://github.com/apache/beam/pull/5916#discussion_r201524390
##########
File path: sdks/python/apache_beam/io/filebasedsink.py
##########
@@ -377,6 +373,9 @@ def __eq__(self, other):
# pylint: disable=unidiomatic-typecheck
return type(self) == type(other) and self.__dict__ == other.__dict__
+ def __hash__(self):
+ return hash((type(self), self.__dict__))
Review comment:
Does `self.__dict__` work here for hashing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 121700)
Time Spent: 40m (was: 0.5h)
> Finish io futurize stage 2: fix the missing pylint3 check in tox.ini
> --------------------------------------------------------------------
>
> Key: BEAM-4751
> URL: https://issues.apache.org/jira/browse/BEAM-4751
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Matthias Feys
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Finish io futurize stage 2: fix the missing pylint3 check in tox.ini
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
