[ 
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=122260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-122260
 ]

ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jul/18 09:44
            Start Date: 12/Jul/18 09:44
    Worklog Time Spent: 10m 
      Work Description: Fematich commented on a change in pull request #5729: 
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r201973579
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/core.py
 ##########
 @@ -698,7 +703,7 @@ def merge_accumulators(self, accumulators, *args, 
**kwargs):
 
     class ReiterableNonEmptyAccumulators(object):
       def __iter__(self):
-        return itertools.ifilter(filter_fn, accumulators)
+        return filter(filter_fn, accumulators)
 
 Review comment:
   @charlesccychen and @tvalentyn: is there more detailed info on the 
benchmarks?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 122260)
    Time Spent: 6h 20m  (was: 6h 10m)

> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
>                 Key: BEAM-4006
>                 URL: https://issues.apache.org/jira/browse/BEAM-4006
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 6h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to