[
https://issues.apache.org/jira/browse/BEAM-4791?focusedWorklogId=123774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123774
]
ASF GitHub Bot logged work on BEAM-4791:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/18 21:33
Start Date: 16/Jul/18 21:33
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5957:
[BEAM-4791] Portable Flink runner integration test.
URL: https://github.com/apache/beam/pull/5957#discussion_r202830333
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DockerJobBundleFactory.java
##########
@@ -69,6 +69,14 @@
public class DockerJobBundleFactory implements JobBundleFactory {
private static final Logger LOG =
LoggerFactory.getLogger(DockerJobBundleFactory.class);
+ /** Factory that creates {@link JobBundleFactory} for the given {@link
JobInfo}. */
+ public interface JobBundleFactoryFactory {
+ DockerJobBundleFactory create(JobInfo jobInfo) throws Exception;
+ }
+ // TODO: a hacky way to override the factory for testing.
+ // Should be replaced with mechanism that let's users configure their own
factory
+ public static JobBundleFactoryFactory factory = (jobInfo) -> new
DockerJobBundleFactory(jobInfo);
Review comment:
Shall we make it final or remove it whole together. We can pass the right
JobBundleFactory instance to avoid FactoryFactory.
This might need restructuring of the code a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 123774)
Time Spent: 1.5h (was: 1h 20m)
> Integration test for portable Flink runner basic batch/streaming execution
> --------------------------------------------------------------------------
>
> Key: BEAM-4791
> URL: https://issues.apache.org/jira/browse/BEAM-4791
> Project: Beam
> Issue Type: Task
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Run a simple pipeline in embedded mode to verify the basic workings of
> JobInvocation/translation/execution for both, batch and streaming. Although
> there will be some overlap with (future) ValidatesRunner, this test is meant
> to run as part of the unit tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
