[ 
https://issues.apache.org/jira/browse/BEAM-4800?focusedWorklogId=123993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123993
 ]

ASF GitHub Bot logged work on BEAM-4800:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jul/18 06:56
            Start Date: 17/Jul/18 06:56
    Worklog Time Spent: 10m 
      Work Description: herohde closed pull request #5954: [BEAM-4800] send 
PutArtifactResponse in BeamFileSystemArtifactStagingService
URL: https://github.com/apache/beam/pull/5954
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactStagingService.java
 
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactStagingService.java
index ee92d32b9db..f059971b6fc 100644
--- 
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactStagingService.java
+++ 
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactStagingService.java
@@ -297,6 +297,7 @@ public void onCompleted() {
           return;
         }
       }
+      outboundObserver.onNext(PutArtifactResponse.newBuilder().build());
       outboundObserver.onCompleted();
     }
   }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 123993)
            Time Spent: 10m
    Remaining Estimate: 0h

> PutArtifactResponse not sent
> ----------------------------
>
>                 Key: BEAM-4800
>                 URL: https://issues.apache.org/jira/browse/BEAM-4800
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>    Affects Versions: Not applicable
>            Reporter: Ryan Williams
>            Assignee: Ryan Williams
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> At time of writing, running portable wordcount fails:
> {code:java}
> ./gradlew -p sdks/python/container docker
> ./gradlew :beam-runners-flink_2.11-job-server:runShadow
> ./gradlew :beam-sdks-python:portableWordCount{code}
> Relevant job-server output:
> {code:java}
> [grpc-default-executor-4] INFO 
> org.apache.beam.runners.fnexecution.artifact.BeamFileSystemArtifactStagingService
>  - Going to stage artifact pickled_main_session to 
> /tmp/flink-artifacts/job_89b631dc-1b97-419f-8995-f3fb5ea3f9df/artifacts/artifact_ea0d10d07f4601782ed647e8f6ba4a055be13674ab79fa0c6e2fa44917c5264c.
> [grpc-default-executor-4] INFO 
> org.apache.beam.runners.fnexecution.artifact.BeamFileSystemArtifactStagingService
>  - Staging artifact completed for 
> /tmp/flink-artifacts/job_89b631dc-1b97-419f-8995-f3fb5ea3f9df/artifacts/artifact_ea0d10d07f4601782ed647e8f6ba4a055be13674ab79fa0c6e2fa44917c5264c
> Jul 15, 2018 7:01:25 PM 
> org.apache.beam.vendor.grpc.v1.io.grpc.internal.ServerCallImpl internalClose
> WARNING: Cancelling the stream with status Status{code=INTERNAL, 
> description=Completed without a response, cause=null}{code}
> A {{PutArtifactResponse}} needs to be sent in response to a 
> {{PutArtifactRequest}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to