[
https://issues.apache.org/jira/browse/BEAM-4814?focusedWorklogId=124621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124621
]
ASF GitHub Bot logged work on BEAM-4814:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/18 21:19
Start Date: 18/Jul/18 21:19
Worklog Time Spent: 10m
Work Description: JohnRudolfLewis commented on a change in pull request
#5983: [BEAM-4814] Add client configuration to aws options
URL: https://github.com/apache/beam/pull/5983#discussion_r203533342
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsModule.java
##########
@@ -234,4 +239,23 @@ public SSEAwsKeyManagementParams deserialize(JsonParser
parser, DeserializationC
return new SSEAwsKeyManagementParams(awsKmsKeyId);
}
}
+
+ @JsonAutoDetect(
+ fieldVisibility = Visibility.NONE,
+ getterVisibility = Visibility.NONE,
+ setterVisibility = Visibility.NONE
+ )
+ interface ClientConfigurationMixin {
Review comment:
I started down the path of a interface mixin that just @JsonIgnore'ed the
properties that would not serialize property (look at my commit history). But
then there were messed up defaults since it was setting those properties to
null rather than their default value. I considered what it would take to make
this mixin properly serialize all those classes, and I saw too low of an ROI. I
considered just adding discrete string properties to the AwsSettings class, but
that did not feel like the right design either. I settled on this as the least
bad solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 124621)
Time Spent: 50m (was: 40m)
> Support for S3FileSystem to work behind a proxy server
> ------------------------------------------------------
>
> Key: BEAM-4814
> URL: https://issues.apache.org/jira/browse/BEAM-4814
> Project: Beam
> Issue Type: Improvement
> Components: io-java-aws
> Reporter: John Rudolf Lewis
> Assignee: Ismaël Mejía
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I want to run a Beam job in my Spark cluster that uses the S3FileSystem. My
> Spark cluster is configured to require a proxy server with authentication in
> order to make outbound connections. A small change is required to enable
> ClientConfiguration to be added to the configuration to enable this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
