[
https://issues.apache.org/jira/browse/BEAM-4806?focusedWorklogId=124665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124665
]
ASF GitHub Bot logged work on BEAM-4806:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/18 22:23
Start Date: 18/Jul/18 22:23
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #5969:
[BEAM-4806][SQL] improve unittest for BeamSqlLine
URL: https://github.com/apache/beam/pull/5969#discussion_r203549018
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/parser/BeamDDLTest.java
##########
@@ -30,6 +30,7 @@
import org.apache.beam.sdk.extensions.sql.impl.parser.impl.BeamSqlParserImpl;
import org.apache.beam.sdk.extensions.sql.impl.utils.CalciteUtils;
import org.apache.beam.sdk.extensions.sql.meta.Table;
+import org.apache.beam.sdk.extensions.sql.meta.provider.test.TestTableProvider;
Review comment:
Did a check and seems like here is a conflict of using `TestTableProvider`
but creating a `Text` table.
This is a slightly refactoring of old code but not relevant to this PR. I
prefer to fix this conflict in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 124665)
Time Spent: 3h 50m (was: 3h 40m)
> Improve BeamSqlLine unit tests
> ------------------------------
>
> Key: BEAM-4806
> URL: https://issues.apache.org/jira/browse/BEAM-4806
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
