[
https://issues.apache.org/jira/browse/BEAM-4653?focusedWorklogId=124674&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124674
]
ASF GitHub Bot logged work on BEAM-4653:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/18 22:42
Start Date: 18/Jul/18 22:42
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5898:
[BEAM-4653] Add support to the Java SDK harness to execute timers.
URL: https://github.com/apache/beam/pull/5898#discussion_r203546771
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/DoFnPTransformRunnerFactory.java
##########
@@ -225,13 +256,13 @@ public final RunnerT createRunnerForPTransform(
throw new IllegalArgumentException("Malformed ParDoPayload", exn);
}
- ImmutableListMultimap.Builder<TupleTag<?>,
FnDataReceiver<WindowedValue<?>>>
Review comment:
Thanks for removing the TupleTag usage. Unfortunately, it looks like we're
still using it all over the place even in portable code. :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 124674)
> Java SDK harness should support user timers
> -------------------------------------------
>
> Key: BEAM-4653
> URL: https://issues.apache.org/jira/browse/BEAM-4653
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Wire up the onTimer method in the Java SDK harness FnApiDoFnRunner connecting
> it to the RemoteGrpcPort read/write that is responsible for
> producing/consumer timers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
