[
https://issues.apache.org/jira/browse/BEAM-4820?focusedWorklogId=125242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125242
]
ASF GitHub Bot logged work on BEAM-4820:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/18 20:43
Start Date: 19/Jul/18 20:43
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #5985: [BEAM-4820][SQL] Add
timeout to Future.get when waiting for Pubsub messages
URL: https://github.com/apache/beam/pull/5985
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonIT.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonIT.java
index 4e1c70aeb9c..196405a72ff 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonIT.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonIT.java
@@ -40,6 +40,7 @@
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;
import org.apache.beam.sdk.extensions.sql.impl.BeamCalciteSchema;
import org.apache.beam.sdk.extensions.sql.impl.BeamSqlEnv;
@@ -262,7 +263,7 @@ public void testSQLLimit() throws Exception {
// wait one minute to allow subscription creation.
Thread.sleep(60 * 1000);
eventsTopic.publish(messages);
- assertThat(queryResult.get().size(), equalTo(3));
+ assertThat(queryResult.get(2, TimeUnit.MINUTES).size(), equalTo(3));
pool.shutdown();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 125242)
Time Spent: 1h 40m (was: 1.5h)
> Add timeout to Future.get when waiting for Pubsub messages
> ----------------------------------------------------------
>
> Key: BEAM-4820
> URL: https://issues.apache.org/jira/browse/BEAM-4820
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Should have a timeout when waiting for Pubsub messages because if unbounded
> limit is broken, the Future.get() will be blocking and never return.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
