[
https://issues.apache.org/jira/browse/BEAM-4076?focusedWorklogId=125553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125553
]
ASF GitHub Bot logged work on BEAM-4076:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/18 16:25
Start Date: 20/Jul/18 16:25
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #5955: [BEAM-4076] Enable
schemas for more runners
URL: https://github.com/apache/beam/pull/5955#issuecomment-406652348
@echauchot thanks for the review! Some comments:
1. Schemas are plumbed through the NewDoFn implementation, which is why we
needed the input and output coders. Schemas are implemented as a special type
of coder (SchemaCoder), so NewDoFn needs those coders to infer schemas. Other
transforms such as CoGroupByKey are (currently) untouched by schemas. There
will be a new schema-specific Join transform (allowing you to join by specific
field names, etc.), but I don't currently plan on changing CoGroupByKey itself.
2. I'll take a look at the apex runner failures, and rebase.
3. I'll look at variable names. I tried to rename a number of them to be
less confusing, but might've missed a few :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 125553)
Time Spent: 14.5h (was: 14h 20m)
> Schema followups
> ----------------
>
> Key: BEAM-4076
> URL: https://issues.apache.org/jira/browse/BEAM-4076
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, dsl-sql, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> This umbrella bug contains subtasks with followups for Beam schemas, which
> were moved from SQL to the core Java SDK and made to be type-name-based
> rather than coder based.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
