[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=126209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126209
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/18 18:38
Start Date: 23/Jul/18 18:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5935:
[BEAM-4176] Initial implementation for running portable runner tests
URL: https://github.com/apache/beam/pull/5935#discussion_r204509017
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
##########
@@ -81,6 +75,23 @@ private static void printUsage(CmdLineParser parser) {
System.err.println();
}
+ private static ServerConfiguration parseServerConfiguration(String[] args) {
+ ServerConfiguration configuration = new ServerConfiguration();
Review comment:
nit: is there a reason why you want the contents of
`parseServerConfiguration` to be outside of `fromParams`, the redirection
reduces the readability of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 126209)
Time Spent: 2h 20m (was: 2h 10m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
