[
https://issues.apache.org/jira/browse/BEAM-4845?focusedWorklogId=126808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126808
]
ASF GitHub Bot logged work on BEAM-4845:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/18 19:06
Start Date: 24/Jul/18 19:06
Worklog Time Spent: 10m
Work Description: tweise closed pull request #6018: [BEAM-4845] Make
BigQueryServices and FakeDatasetService public to fix the build
URL: https://github.com/apache/beam/pull/6018
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java
index 395f66bab00..b52cfec7592 100644
---
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java
@@ -35,7 +35,7 @@
import org.apache.beam.sdk.values.ValueInSingleWindow;
/** An interface for real, mock, or fake implementations of Cloud BigQuery
services. */
-interface BigQueryServices extends Serializable {
+public interface BigQueryServices extends Serializable {
/** Returns a real, mock, or fake {@link JobService}. */
JobService getJobService(BigQueryOptions bqOptions);
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
index 33a24e7a06b..9d0692a26e7 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
+++
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
@@ -46,7 +46,7 @@
import org.apache.beam.sdk.values.ValueInSingleWindow;
/** A fake dataset service that can be serialized, for use in
testReadFromTable. */
-class FakeDatasetService implements DatasetService, Serializable {
+public class FakeDatasetService implements DatasetService, Serializable {
// Table information must be static, as each ParDo will get a separate
instance of
// FakeDatasetServices, and they must all modify the same storage.
static com.google.common.collect.Table<String, String, Map<String,
TableContainer>> tables;
@@ -73,7 +73,7 @@ public Table getTable(TableReference tableRef) throws
InterruptedException, IOEx
}
}
- List<TableRow> getAllRows(String projectId, String datasetId, String tableId)
+ public List<TableRow> getAllRows(String projectId, String datasetId, String
tableId)
throws InterruptedException, IOException {
synchronized (tables) {
return getTableContainer(projectId, datasetId, tableId).getRows();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 126808)
Time Spent: 1h 40m (was: 1.5h)
> Nexmark suites do not compile
> -----------------------------
>
> Key: BEAM-4845
> URL: https://issues.apache.org/jira/browse/BEAM-4845
> Project: Beam
> Issue Type: Bug
> Components: examples-nexmark
> Reporter: Lukasz Gajowy
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This is due to this PR: [https://github.com/apache/beam/pull/5341.] Some
> interfaces/classes had their visibility changed and this caused nexmark to
> fail at compilation phase.
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_Nexmark_Direct/112/console]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
