[
https://issues.apache.org/jira/browse/BEAM-4860?focusedWorklogId=127457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127457
]
ASF GitHub Bot logged work on BEAM-4860:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/18 18:39
Start Date: 25/Jul/18 18:39
Worklog Time Spent: 10m
Work Description: lukecwik opened a new pull request #6064: [BEAM-4860]
Ensure that shaded artifacts that are produced don't leak non org.apache.beam
classes
URL: https://github.com/apache/beam/pull/6064
We also fix the single issue where we weren't shading
com/google/thirdparty/publicsuffix from Guava correctly.
Note that I dropped testing the test jar as it matters a lot less as a
vended artifact. It can be re-added if needed at a future date.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 127457)
Time Spent: 10m
Remaining Estimate: 0h
> com/google/thirdparty/publicsuffix is not shaded along with guava
> -----------------------------------------------------------------
>
> Key: BEAM-4860
> URL: https://issues.apache.org/jira/browse/BEAM-4860
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Affects Versions: 2.5.0
> Reporter: Fred Wulff
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> com.google.common is shaded, but com.google.thirdparty.publicsuffix (which is
> part of the guava library) is not, so attempting to use a more recent version
> of Guava while importing the beam libraries leads to conflicts
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
