[
https://issues.apache.org/jira/browse/BEAM-3709?focusedWorklogId=127501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127501
]
ASF GitHub Bot logged work on BEAM-3709:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/18 20:37
Start Date: 25/Jul/18 20:37
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #6014: [BEAM-3709]
Implementing new combine URNs in python.
URL: https://github.com/apache/beam/pull/6014
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/runners/worker/bundle_processor.py
b/sdks/python/apache_beam/runners/worker/bundle_processor.py
index 958731d0ce4..33c8744a7b4 100644
--- a/sdks/python/apache_beam/runners/worker/bundle_processor.py
+++ b/sdks/python/apache_beam/runners/worker/bundle_processor.py
@@ -641,6 +641,50 @@ def create(factory, transform_id, transform_proto,
payload, consumers):
factory, transform_proto, payload, consumers, 'extract')
[email protected]_urn(
+ common_urns.combine_components.COMBINE_PER_KEY_PRECOMBINE.urn,
+ beam_runner_api_pb2.CombinePayload)
+def create(factory, transform_id, transform_proto, payload, consumers):
+ serialized_combine_fn = pickler.dumps(
+ (beam.CombineFn.from_runner_api(payload.combine_fn, factory.context),
+ [], {}))
+ return factory.augment_oldstyle_op(
+ operations.PGBKCVOperation(
+ transform_proto.unique_name,
+ operation_specs.WorkerPartialGroupByKey(
+ serialized_combine_fn,
+ None,
+ [factory.get_only_output_coder(transform_proto)]),
+ factory.counter_factory,
+ factory.state_sampler),
+ transform_proto.unique_name,
+ consumers)
+
+
[email protected]_urn(
+ common_urns.combine_components.COMBINE_PER_KEY_MERGE_ACCUMULATORS.urn,
+ beam_runner_api_pb2.CombinePayload)
+def create(factory, transform_id, transform_proto, payload, consumers):
+ return _create_combine_phase_operation(
+ factory, transform_proto, payload, consumers, 'merge')
+
+
[email protected]_urn(
+ common_urns.combine_components.COMBINE_PER_KEY_EXTRACT_OUTPUTS.urn,
+ beam_runner_api_pb2.CombinePayload)
+def create(factory, transform_id, transform_proto, payload, consumers):
+ return _create_combine_phase_operation(
+ factory, transform_proto, payload, consumers, 'extract')
+
+
[email protected]_urn(
+ common_urns.combine_components.COMBINE_GROUPED_VALUES.urn,
+ beam_runner_api_pb2.CombinePayload)
+def create(factory, transform_id, transform_proto, payload, consumers):
+ return _create_combine_phase_operation(
+ factory, transform_proto, payload, consumers, 'all')
+
+
def _create_combine_phase_operation(
factory, transform_proto, payload, consumers, phase):
serialized_combine_fn = pickler.dumps(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 127501)
Time Spent: 1h (was: 50m)
> Implement the portable lifted Combiner transforms in Python SDK
> ---------------------------------------------------------------
>
> Key: BEAM-3709
> URL: https://issues.apache.org/jira/browse/BEAM-3709
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, sdk-py-harness
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These
> parts need to be implemented in the Python SDK harness so that the SDK can
> actually execute them when receiving Combine transforms with the
> corresponding URNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
