[
https://issues.apache.org/jira/browse/BEAM-4658?focusedWorklogId=127909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127909
]
ASF GitHub Bot logged work on BEAM-4658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/18 20:07
Start Date: 26/Jul/18 20:07
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6050:
[BEAM-4658] Update pipeline representation in runner support libraries to
handle timers.
URL: https://github.com/apache/beam/pull/6050#discussion_r205586171
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/ImmutableExecutableStageTest.java
##########
@@ -58,11 +60,13 @@ public void ofFullComponentsOnlyHasStagePTransforms()
throws Exception {
.setDoFn(RunnerApi.SdkFunctionSpec.newBuilder().setEnvironmentId("foo"))
.putSideInputs("side_input",
RunnerApi.SideInput.getDefaultInstance())
.putStateSpecs("user_state",
RunnerApi.StateSpec.getDefaultInstance())
+ .putTimerSpecs("timer",
RunnerApi.TimerSpec.getDefaultInstance())
.build()
.toByteString()))
.build();
PCollection input =
PCollection.newBuilder().setUniqueName("input.out").build();
PCollection sideInput =
PCollection.newBuilder().setUniqueName("sideInput.in").build();
+ PCollection timer =
PCollection.newBuilder().setUniqueName("timer.out").build();
Review comment:
It is confusing to reference the single timer collection as "timer.out" when
it is used for both input and output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 127909)
Time Spent: 3h 40m (was: 3.5h)
> Update pipeline representation in runner support libraries to handle timers
> ---------------------------------------------------------------------------
>
> Key: BEAM-4658
> URL: https://issues.apache.org/jira/browse/BEAM-4658
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Expose relevant timer information on *ExecutableStage* to runners
> Update fusion logic to handle timers.
> Provide execution time interface to fire timers into *RemoteBundle*s and also
> to receive new timers that are being set.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
