[
https://issues.apache.org/jira/browse/BEAM-4808?focusedWorklogId=127937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127937
]
ASF GitHub Bot logged work on BEAM-4808:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/18 22:21
Start Date: 26/Jul/18 22:21
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #6006:
[BEAM-4808][SQL] add e2e test for BeamSqlLine.
URL: https://github.com/apache/beam/pull/6006#discussion_r205620284
##########
File path: sdks/java/extensions/sql/jdbc/build.gradle
##########
@@ -51,13 +55,6 @@ shadowJar {
}
}
-test {
- doFirst {
- // Assert everything is in the output or test jar
- assert classpath.size() == 2
Review comment:
This is testing that we are actually testing the JDBC jar. You can not
remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 127937)
Time Spent: 5h 40m (was: 5.5h)
> Add an integration test for BeamSqlLine
> ---------------------------------------
>
> Key: BEAM-4808
> URL: https://issues.apache.org/jira/browse/BEAM-4808
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
