[
https://issues.apache.org/jira/browse/BEAM-4808?focusedWorklogId=129545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-129545
]
ASF GitHub Bot logged work on BEAM-4808:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/18 00:07
Start Date: 01/Aug/18 00:07
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #6006:
[BEAM-4808][SQL] add e2e test for BeamSqlLine.
URL: https://github.com/apache/beam/pull/6006#discussion_r206721116
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java
##########
@@ -154,13 +160,49 @@ public TopicPath topicPath() {
return eventsTopicPath;
}
+ public List<SubscriptionPath> listSubscriptions(ProjectPath projectPath,
TopicPath topicPath)
+ throws IOException {
+ return pubsub.listSubscriptions(projectPath, topicPath);
+ }
+
/** Publish messages to {@link #topicPath()}. */
public void publish(List<PubsubMessage> messages) throws IOException {
List<PubsubClient.OutgoingMessage> outgoingMessages =
messages.stream().map(this::toOutgoingMessage).collect(toList());
pubsub.publish(eventsTopicPath, outgoingMessages);
}
+ /**
+ * Check if topics exist.
+ *
+ * @param project GCP project identifier.
+ * @param timeoutDuration Joda duration that sets a period of time before
checking times out.
+ */
+ public void checkIfTopicExists(String project, Duration timeoutDuration)
Review comment:
nit: I would call it `checkIfAnySubscriptionExists()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 129545)
Time Spent: 17h (was: 16h 50m)
> Add an integration test for BeamSqlLine
> ---------------------------------------
>
> Key: BEAM-4808
> URL: https://issues.apache.org/jira/browse/BEAM-4808
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 17h
> Remaining Estimate: 0h
>
> Test non group by window queries in Beam SQL Shell tutorial.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
