[
https://issues.apache.org/jira/browse/BEAM-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566869#comment-16566869
]
Jeroen Steggink commented on BEAM-1240:
---------------------------------------
Furthermore, after some testing, I see the getWatermark() method can return
null. When running with the direct-runner, I get an NPE because the first time
oldestTimeStamp is null. Maybe you ca add a null check and if null set it to
Instant.now()?
[https://github.com/jbonofre/beam/blob/f1665f47ff10679a2a54c1879fce6d77151fa90a/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIO.java#L385]
Testing it with the flink local runner, I never see it calling the
finalizeCheckpoint method in RabbitMQCheckpointMark. Which means, the RabbitMq
messages are never acknowledged. Have you tried it?
> Create RabbitMqIO
> -----------------
>
> Key: BEAM-1240
> URL: https://issues.apache.org/jira/browse/BEAM-1240
> Project: Beam
> Issue Type: New Feature
> Components: io-ideas
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 2.6.0
>
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
