[
https://issues.apache.org/jira/browse/BEAM-4833?focusedWorklogId=130292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-130292
]
ASF GitHub Bot logged work on BEAM-4833:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/18 15:49
Start Date: 02/Aug/18 15:49
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6005:
[BEAM-4833] Add support for user req.txt for portable python
URL: https://github.com/apache/beam/pull/6005#discussion_r207278720
##########
File path: sdks/python/scripts/add_requirements.sh
##########
@@ -0,0 +1,42 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# This script builds a Docker container with the user specified requirements
on top of
+# an existing Python worker Docker container (either one you build from source
as
+# described in CONTAINERS.md or from a released Docker container).
+
Review comment:
Could add a note about how to use this script. A note about having a
requirements file and probably an account on bintray?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 130292)
Time Spent: 1.5h (was: 1h 20m)
> Add support for users specifying a requirements.txt for their Python portable
> container
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-4833
> URL: https://issues.apache.org/jira/browse/BEAM-4833
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: holdenk
> Assignee: holdenk
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> It's pretty common that Python scripts require extra dependencies, even the
> tensorflow model analysis TFMA example requires a different version of TF
> than the one we install by default. While users can roll their own container
> or edit the Dockerfile, it would probably be useful to provide an easier path
> to integrating their dependencies.
> While we support automatically installing the dependencies at runtime on the
> workers, this can be very slow, especially for things like tensorflow, arrow,
> or other numeric heavy code.
> Another alternative could be a simple script to augment the existing base
> image.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
