[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=130737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-130737
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/18 06:24
Start Date: 03/Aug/18 06:24
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r207450985
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1712,6 +1718,10 @@ def __eq__(self, other):
and self.timestamp_combiner == other.timestamp_combiner)
return False
+ def __hash__(self):
+ return hash((type(self), self.windowfn, self.accumulation_mode,
Review comment:
Unfortunately removing `__hash__` here, results in `TypeError: unhashable
type: 'Windowing'` for ` test_top_prefixes`.
However, looking at self._default, it seems OK to remove it from the hash,
since it's actually a check on the other class variables. Therefore I think
`__eq__` and `__hash__` are still in sync. I removed `type(self)` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 130737)
Time Spent: 15h 40m (was: 15.5h)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 15h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
