[
https://issues.apache.org/jira/browse/BEAM-4573?focusedWorklogId=132762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132762
]
ASF GitHub Bot logged work on BEAM-4573:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/18 23:07
Start Date: 08/Aug/18 23:07
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #6184: [BEAM-4573] add
missing annotation for "||"
URL: https://github.com/apache/beam/pull/6184
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
index a2b558be3c5..9e9ab941e77 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
@@ -525,10 +525,13 @@ public void testComparisonOperatorFunction() {
@SqlOperatorTest(name = "SUBSTRING", kind = "OTHER_FUNCTION")
@SqlOperatorTest(name = "TRIM", kind = "TRIM")
@SqlOperatorTest(name = "UPPER", kind = "OTHER_FUNCTION")
+ @SqlOperatorTest(name = "||", kind = "OTHER")
public void testStringFunctions() throws Exception {
SqlExpressionChecker checker =
new SqlExpressionChecker()
.addExpr("'hello' || ' world' = 'hello world'")
+ .addExpr("'hello' || '' = 'hello'")
+ .addExpr("'' || '' = ''")
.addExpr("CHAR_LENGTH('hello') = 5")
.addExpr("CHARACTER_LENGTH('hello') = 5")
.addExpr("INITCAP('hello world') = 'Hello World'")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 132762)
Time Spent: 2.5h (was: 2h 20m)
> Test all SQL standard operators at the DSL level
> ------------------------------------------------
>
> Key: BEAM-4573
> URL: https://issues.apache.org/jira/browse/BEAM-4573
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
