[
https://issues.apache.org/jira/browse/BEAM-5113?focusedWorklogId=133062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133062
]
ASF GitHub Bot logged work on BEAM-5113:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/18 17:21
Start Date: 09/Aug/18 17:21
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #6186:
[BEAM-5113][SQL] Add NOT LIKE based on LIKE expression
URL: https://github.com/apache/beam/pull/6186#discussion_r209012026
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutor.java
##########
@@ -278,7 +279,9 @@ private static BeamSqlExpression
getBeamSqlExpression(RexNode rexNode) {
case "LIKE":
ret = new BeamSqlLikeExpression(subExps);
break;
-
+ case "NOT LIKE":
+ ret = new BeamSqlNotLikeExpression(subExps);
Review comment:
I see. It makes sense to think from this perspective. Readers might stop
reading when read the class name (which self-explains the functionality of
class). However, if readers have to dig into the implementation of the separate
class, it indeed reduces readability of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 133062)
Time Spent: 1h (was: 50m)
> Test NOT LIKE
> -------------
>
> Key: BEAM-5113
> URL: https://issues.apache.org/jira/browse/BEAM-5113
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
