[
https://issues.apache.org/jira/browse/BEAM-3286?focusedWorklogId=133286&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133286
]
ASF GitHub Bot logged work on BEAM-3286:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/18 21:36
Start Date: 09/Aug/18 21:36
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #6197:
[BEAM-3286] Add preliminary Go support for side input
URL: https://github.com/apache/beam/pull/6197#discussion_r209072485
##########
File path: sdks/go/pkg/beam/core/runtime/harness/statemgr.go
##########
@@ -0,0 +1,310 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package harness
+
+import (
+ "context"
+ "fmt"
+ "io"
+ "sync"
+ "sync/atomic"
+ "time"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/runtime/exec"
+ "github.com/apache/beam/sdks/go/pkg/beam/log"
+ pb "github.com/apache/beam/sdks/go/pkg/beam/model/fnexecution_v1"
+ "github.com/golang/protobuf/proto"
+ "github.com/pkg/errors"
+)
+
+// ScopedStateManager scopes the global gRPC state manager to a single
instruction.
+// The indirection makes it easier to control access.
+type ScopedSideInputReader struct {
+ mgr *StateChannelManager
+ instID string
+
+ opened []io.Closer // track open readers to force close all
+ closed bool
+ mu sync.Mutex
+}
+
+func NewScopedSideInputReader(mgr *StateChannelManager, instID string)
*ScopedSideInputReader {
Review comment:
Exported functions, even relatively obvious ones, should probably have a
comment
// NewScopedSideInputReader ...
Alternatively, this only seems to be invoked in this package. Does it need
to be exported at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 133286)
Time Spent: 40m (was: 0.5h)
> Go SDK support for portable side input
> --------------------------------------
>
> Key: BEAM-3286
> URL: https://issues.apache.org/jira/browse/BEAM-3286
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Labels: portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
