[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133718
]
ASF GitHub Bot logged work on BEAM-5114:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/18 17:47
Start Date: 10/Aug/18 17:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r209336715
##########
File path: examples/java/direct/build.gradle
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
This is a subset of the maven archetypes functionality that already exists
since the maven archetypes allows people to edit the code and is useful for
them to build their own pipelines.
Also, in my opinion Maven should only contain libraries and not
applications. It is dangerous to release jars that contain code which contains
unrepackaged libraries to Maven. This is an issue in several prominent projects
where they include guava or some other version inside their jar leading to user
confusion because of MethodNotFoundErrors. In that regard I would be fine with
having these available on the Beam website as direct downloads in addition to
the archetypes quickstart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 133718)
Time Spent: 1h 40m (was: 1.5h)
> Create example uber jars for supported runners
> ----------------------------------------------
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
> Reporter: Ben Sidhom
> Assignee: Ben Sidhom
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
