[
https://issues.apache.org/jira/browse/BEAM-4475?focusedWorklogId=133780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133780
]
ASF GitHub Bot logged work on BEAM-4475:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/18 19:34
Start Date: 10/Aug/18 19:34
Worklog Time Spent: 10m
Work Description: herohde closed pull request #6096: [BEAM-4475] Include
Go regression tests in precommit
URL: https://github.com/apache/beam/pull/6096
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index d98ce9b3d71..cec9da7a0cd 100644
--- a/build.gradle
+++ b/build.gradle
@@ -196,9 +196,9 @@ task javaPostCommit() {
task goPreCommit() {
dependsOn ":rat"
dependsOn ":beam-sdks-go:test"
+ dependsOn ":beam-sdks-go-test:test"
dependsOn ":beam-sdks-go-examples:build"
- dependsOn ":beam-sdks-go-test:build"
// Ensure all container Go boot code builds as well.
dependsOn ":beam-sdks-java-container:build"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 133780)
Time Spent: 50m (was: 40m)
> Go precommit should include "go test ./..."
> -------------------------------------------
>
> Key: BEAM-4475
> URL: https://issues.apache.org/jira/browse/BEAM-4475
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Minor
> Fix For: 2.6.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> It would have prevented a recent break caused by a green PR:
> https://github.com/apache/beam/pull/5558.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
