[ https://issues.apache.org/jira/browse/BEAM-5101?focusedWorklogId=134280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134280 ]
ASF GitHub Bot logged work on BEAM-5101: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Aug/18 20:11 Start Date: 13/Aug/18 20:11 Worklog Time Spent: 10m Work Description: amaliujia edited a comment on issue #6207: [BEAM-5101][SQL] Improve tests of Floor and Ceil functions URL: https://github.com/apache/beam/pull/6207#issuecomment-412226519 For example, [code](https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/math/BeamSqlCeilExpression.java#L41) shows the conversion from original type to `Double`, and [code](https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java#L127) shows creating a Row with schema specified during creating table, which will have a mismatch during verification step of Row. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 134280) Time Spent: 1h 20m (was: 1h 10m) > Improve Floor and Ceil tests at DSL level > ----------------------------------------- > > Key: BEAM-5101 > URL: https://issues.apache.org/jira/browse/BEAM-5101 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql > Reporter: Rui Wang > Assignee: Rui Wang > Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)