[
https://issues.apache.org/jira/browse/BEAM-5142?focusedWorklogId=134346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134346
]
ASF GitHub Bot logged work on BEAM-5142:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/18 23:30
Start Date: 13/Aug/18 23:30
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #6214:
[BEAM-5142] Improve PubsubIT
URL: https://github.com/apache/beam/pull/6214#discussion_r209790184
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonIT.java
##########
@@ -264,7 +273,7 @@ public void testSQLLimit() throws Exception {
});
// wait one minute to allow subscription creation.
- Thread.sleep(60 * 1000);
+ eventsTopic.checkIfAnySubscriptionExists(project,
Duration.standardMinutes(1));
Review comment:
It would be more correct to pull `project` out of the pipeline you're using
here, rather then from `TestPipeline` globally. I believe
`pipeline.getOptions().as(GcpOptions.class).getProject()` should work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 134346)
Time Spent: 1h 10m (was: 1h)
> Improve Pubsub e2e test
> -----------------------
>
> Key: BEAM-5142
> URL: https://issues.apache.org/jira/browse/BEAM-5142
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
