[
https://issues.apache.org/jira/browse/BEAM-5145?focusedWorklogId=135063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135063
]
ASF GitHub Bot logged work on BEAM-5145:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/18 17:08
Start Date: 15/Aug/18 17:08
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #6212: [BEAM-5145] Make
PTransform names stable in Join/CoGroupByKey
URL: https://github.com/apache/beam/pull/6212
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java
index 29ae180224a..9053ad0b172 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java
@@ -111,10 +111,11 @@ private CoGroupByKey() {}
unionTables = unionTables.and(unionTable);
}
- PCollection<KV<K, RawUnionValue>> flattenedTable =
unionTables.apply(Flatten.pCollections());
+ PCollection<KV<K, RawUnionValue>> flattenedTable =
+ unionTables.apply("Flatten", Flatten.pCollections());
PCollection<KV<K, Iterable<RawUnionValue>>> groupedTable =
- flattenedTable.apply(GroupByKey.create());
+ flattenedTable.apply("GBK", GroupByKey.create());
CoGbkResultSchema tupleTags = input.getCoGbkResultSchema();
PCollection<KV<K, CoGbkResult>> result =
diff --git
a/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java
b/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java
index 68598d68138..42d1ed67e42 100644
---
a/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java
+++
b/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java
@@ -57,10 +57,11 @@
PCollection<KV<K, CoGbkResult>> coGbkResultCollection =
KeyedPCollectionTuple.of(v1Tuple, leftCollection)
.and(v2Tuple, rightCollection)
- .apply(CoGroupByKey.create());
+ .apply("CoGBK", CoGroupByKey.create());
return coGbkResultCollection
.apply(
+ "Join",
ParDo.of(
new DoFn<KV<K, CoGbkResult>, KV<K, KV<V1, V2>>>() {
@ProcessElement
@@ -111,10 +112,11 @@ public void processElement(ProcessContext c) {
PCollection<KV<K, CoGbkResult>> coGbkResultCollection =
KeyedPCollectionTuple.of(v1Tuple, leftCollection)
.and(v2Tuple, rightCollection)
- .apply(CoGroupByKey.create());
+ .apply("CoGBK", CoGroupByKey.create());
return coGbkResultCollection
.apply(
+ "Join",
ParDo.of(
new DoFn<KV<K, CoGbkResult>, KV<K, KV<V1, V2>>>() {
@ProcessElement
@@ -169,10 +171,11 @@ public void processElement(ProcessContext c) {
PCollection<KV<K, CoGbkResult>> coGbkResultCollection =
KeyedPCollectionTuple.of(v1Tuple, leftCollection)
.and(v2Tuple, rightCollection)
- .apply(CoGroupByKey.create());
+ .apply("CoGBK", CoGroupByKey.create());
return coGbkResultCollection
.apply(
+ "Join",
ParDo.of(
new DoFn<KV<K, CoGbkResult>, KV<K, KV<V1, V2>>>() {
@ProcessElement
@@ -231,10 +234,11 @@ public void processElement(ProcessContext c) {
PCollection<KV<K, CoGbkResult>> coGbkResultCollection =
KeyedPCollectionTuple.of(v1Tuple, leftCollection)
.and(v2Tuple, rightCollection)
- .apply(CoGroupByKey.create());
+ .apply("CoGBK", CoGroupByKey.create());
return coGbkResultCollection
.apply(
+ "Join",
ParDo.of(
new DoFn<KV<K, CoGbkResult>, KV<K, KV<V1, V2>>>() {
@ProcessElement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 135063)
Time Spent: 1h 20m (was: 1h 10m)
> Make PTransform names stable in Join/CoGroupByKey
> -------------------------------------------------
>
> Key: BEAM-5145
> URL: https://issues.apache.org/jira/browse/BEAM-5145
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Leen Toelen
> Priority: Trivial
> Fix For: 2.7.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
