[
https://issues.apache.org/jira/browse/BEAM-2732?focusedWorklogId=135159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135159
]
ASF GitHub Bot logged work on BEAM-2732:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/18 21:24
Start Date: 15/Aug/18 21:24
Worklog Time Spent: 10m
Work Description: pabloem commented on issue #5356:
[BEAM-2732][BEAM-4028] Logging relies on StateSampler for context
URL: https://github.com/apache/beam/pull/5356#issuecomment-413342234
This was meant to be removed, because optimizations are no longer needed.
This list only ever contains one element per work item.
On Wed, Aug 15, 2018 at 2:23 PM Charles Chen <[email protected]>
wrote:
> *@charlesccychen* commented on this pull request.
>
> In sdks/python/apache_beam/runners/worker/logger.py
> <https://github.com/apache/beam/pull/5356#discussion_r210414347>:
>
> > @@ -34,7 +34,6 @@ class _PerThreadWorkerData(threading.local):
>
> def __init__(self):
> super(_PerThreadWorkerData, self).__init__()
> - # TODO(robertwb): Consider starting with an initial (ignored) ~20
elements
>
> Part of this TODO was accidentally deleted. Please fix.
>
> —
> You are receiving this because you modified the open/close state.
>
>
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/5356#discussion_r210414347>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ABPc7Ot3bFoE0T5jPC3Z5l-RCPxci4NFks5uRJFZgaJpZM4T-S3o>
> .
>
--
Got feedback? go/pabloem-feedback
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 135159)
Time Spent: 19.5h (was: 19h 20m)
> State tracking in Python is inefficient and has duplicated code
> ---------------------------------------------------------------
>
> Key: BEAM-2732
> URL: https://issues.apache.org/jira/browse/BEAM-2732
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Fix For: 2.6.0
>
> Time Spent: 19.5h
> Remaining Estimate: 0h
>
> e.g logging and metrics keep state separately. State tracking should be
> unified.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
