[
https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=135170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135170
]
ASF GitHub Bot logged work on BEAM-4809:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/18 22:04
Start Date: 15/Aug/18 22:04
Worklog Time Spent: 10m
Work Description: pabloem closed pull request #5970: [BEAM-4809] Build
javadoc on :javaPreCommit and :javaPostCommit
URL: https://github.com/apache/beam/pull/5970
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index dcfadbbc414..2eb93a3a5ff 100644
--- a/build.gradle
+++ b/build.gradle
@@ -184,6 +184,7 @@ task javaPreCommit() {
dependsOn ":beam-sdks-java-core:buildDependents"
dependsOn ":beam-examples-java:preCommit"
dependsOn ":beam-sdks-java-extensions-sql-jdbc:preCommit"
+ dependsOn ":beam-sdks-java-javadoc:allJavadoc"
}
task javaPostCommit() {
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 6916ab1e794..c778df9ac43 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -643,6 +643,9 @@ class BeamModulePlugin implements Plugin<Project> {
}
project.checkstyle { toolVersion = "8.7" }
+ // Ensure check runs javadoc
+ project.check.dependsOn project.javadoc
+
// Apply the eclipse and apt-eclipse plugins. This adds the "eclipse"
task and
// connects the apt-eclipse plugin to update the eclipse project files
// with the instructions needed to run apt within eclipse to handle the
AutoValue
diff --git a/sdks/java/javadoc/build.gradle b/sdks/java/javadoc/build.gradle
index 240aef4f21a..4f73e23ee13 100644
--- a/sdks/java/javadoc/build.gradle
+++ b/sdks/java/javadoc/build.gradle
@@ -78,6 +78,10 @@ for (String exportedJavadocProject :
exportedJavadocProjects) {
evaluationDependsOn(exportedJavadocProject)
}
+task allJavadoc() {
+ dependsOn exportedJavadocProjects.collect { "$it:javadoc" }
+}
+
task aggregateJavadoc(type: Javadoc) {
source exportedJavadocProjects.collect { project(it).sourceSets.main.allJava
}
classpath = files(exportedJavadocProjects.collect {
project(it).sourceSets.main.compileClasspath })
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 135170)
Time Spent: 4h 20m (was: 4h 10m)
> Java preCommit and postCommit should build javadoc to check it builds ok
> ------------------------------------------------------------------------
>
> Key: BEAM-4809
> URL: https://issues.apache.org/jira/browse/BEAM-4809
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Affects Versions: 2.5.0
> Reporter: Alan Myrvold
> Assignee: Alan Myrvold
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Java preCommit and postCommit should build javadoc to check it builds ok
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
