[
https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=135562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135562
]
ASF GitHub Bot logged work on BEAM-4130:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/18 01:26
Start Date: 17/Aug/18 01:26
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6238:
[BEAM-4130] Build Docker image for Flink's JobServer
URL: https://github.com/apache/beam/pull/6238#discussion_r210784330
##########
File path: runners/flink/job-server-container/flink-job-server.sh
##########
@@ -0,0 +1,29 @@
+#!/bin/sh
+###############################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###############################################################################
+
+### Just a simple script to bootstrap the FlinkJobServerDriver
+### For the environment, see the Dockerfile
+
+# The following (forking to the background, then waiting) enables to use
CTRL+C to kill the container.
+# We're PID 1 which doesn't handle signals. By forking the Java process to the
background,
+# a PID > 1 is created which handles signals. After the command shuts down,
the script and
+# thus the container will also exit.
+
+java -cp "jars/*" org.apache.beam.runners.flink.FlinkJobServerDriver "$@" &
+wait
Review comment:
please add a new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 135562)
Time Spent: 4h 40m (was: 4.5h)
> Portable Flink runner JobService entry point in a Docker container
> ------------------------------------------------------------------
>
> Key: BEAM-4130
> URL: https://issues.apache.org/jira/browse/BEAM-4130
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Ben Sidhom
> Assignee: Maximilian Michels
> Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> The portable Flink runner exists as a Job Service that runs somewhere. We
> need a main entry point that itself spins up the job service (and artifact
> staging service). The main program itself should be packaged into an uberjar
> such that it can be run locally or submitted to a Flink deployment via `flink
> run`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
