[ 
https://issues.apache.org/jira/browse/BEAM-5155?focusedWorklogId=135886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135886
 ]

ASF GitHub Bot logged work on BEAM-5155:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Aug/18 22:09
            Start Date: 17/Aug/18 22:09
    Worklog Time Spent: 10m 
      Work Description: herohde closed pull request #6233: [BEAM-5155] Check 
sdk absolute path before installing
URL: https://github.com/apache/beam/pull/6233
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/python/container/piputil.go b/sdks/python/container/piputil.go
index 1c0faa39c91..01c289ac2ae 100644
--- a/sdks/python/container/piputil.go
+++ b/sdks/python/container/piputil.go
@@ -160,7 +160,7 @@ func installSdk(files []string, workDir string, sdkSrcFile 
string, acceptableWhl
                log.Printf("Could not install Apache Beam SDK from a wheel: %v, 
proceeding to install SDK from source tarball.", err)
        }
        if !required {
-               _, err := os.Stat(sdkSrcFile)
+               _, err := os.Stat(filepath.Join(workDir, sdkSrcFile))
                if os.IsNotExist(err) {
                        return nil
                }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 135886)
    Time Spent: 0.5h  (was: 20m)

> Custom sdk_location parameter not working with fn_api
> -----------------------------------------------------
>
>                 Key: BEAM-5155
>                 URL: https://issues.apache.org/jira/browse/BEAM-5155
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-harness
>            Reporter: Ankur Goenka
>            Assignee: Ankur Goenka
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The custom sdk_location is not taking affect in portability framework.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to