[
https://issues.apache.org/jira/browse/BEAM-3194?focusedWorklogId=135939&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135939
]
ASF GitHub Bot logged work on BEAM-3194:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/18 00:41
Start Date: 18/Aug/18 00:41
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6220:
[BEAM-3194] Add ValidatesRunner test for support of @RequiresStableInput
URL: https://github.com/apache/beam/pull/6220#discussion_r211057120
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExplicitShardedFile.java
##########
@@ -49,18 +49,36 @@
.withMaxRetries(MAX_READ_RETRIES);
private final List<Metadata> files;
+ private final String filePattern;
/** Constructs an {@link ExplicitShardedFile} for the given files. */
public ExplicitShardedFile(Collection<String> files) throws IOException {
this.files = new ArrayList<>();
+ this.filePattern = null;
for (String file : files) {
this.files.add(FileSystems.matchSingleFileSpec(file));
}
}
+ /**
+ * Constructs an {@link ExplicitShardedFile} for the given file pattern.
+ *
+ * <p>For internal use only.
+ */
+ public ExplicitShardedFile(String filePattern) {
Review comment:
Adding this constructor is specifically against why this class exists. The
intent is to not require a filesystem match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 135939)
Time Spent: 10m
Remaining Estimate: 0h
> Support annotating that a DoFn requires stable / deterministic input for
> replay/retry
> -------------------------------------------------------------------------------------
>
> Key: BEAM-3194
> URL: https://issues.apache.org/jira/browse/BEAM-3194
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Kenneth Knowles
> Assignee: Yueyang Qiu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See the thread:
> https://lists.apache.org/thread.html/5fd81ce371aeaf642665348f8e6940e308e04275dd7072f380f9f945@%3Cdev.beam.apache.org%3E
> We need this in order to have truly cross-runner end-to-end exactly once via
> replay + idempotence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
