[
https://issues.apache.org/jira/browse/BEAM-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585426#comment-16585426
]
Valentyn Tymofieiev commented on BEAM-5069:
-------------------------------------------
Thanks for following up, [~h4rry]. We should add a unit test that catches this
regression before we close this. Just in case (since this issue attracted your
attention), let me know if adding such test is something you may be interested
in.
> Incorrect string type check in _OutputProcessor.process_outputs.
> ----------------------------------------------------------------
>
> Key: BEAM-5069
> URL: https://issues.apache.org/jira/browse/BEAM-5069
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
>
> Due to _# cython: language_level=3_ directive in
> [common.py|https://github.com/apache/beam/blob/8f1d86ea7bd5b118bc7e638d4d484445101526a1/sdks/python/apache_beam/runners/common.py#L18],
> the type check in
> [common.py|https://github.com/apache/beam/blob/8f1d86ea7bd5b118bc7e638d4d484445101526a1/sdks/python/apache_beam/runners/common.py#L729]
> does not recognize Python 2 strings, which have type 'bytes'.
> This causes pipelines to crash when this codepath is executed in Cythonized
> version of the SDK.
> The regression happened during ongoing efforts to make Beam codebase Python 3
> compatible.
> The fix will need to be cherry-picked into the 2.6.0 release.
> Working on the fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
