[
https://issues.apache.org/jira/browse/BEAM-5168?focusedWorklogId=136335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136335
]
ASF GitHub Bot logged work on BEAM-5168:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/18 23:03
Start Date: 20/Aug/18 23:03
Worklog Time Spent: 10m
Work Description: tweise closed pull request #6248: [BEAM-5168] Redirect
Flink jobserver commons-logging to slf4j.
URL: https://github.com/apache/beam/pull/6248
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/flink/job-server/build.gradle
b/runners/flink/job-server/build.gradle
index 4059d7303fb..a6ee49c1c42 100644
--- a/runners/flink/job-server/build.gradle
+++ b/runners/flink/job-server/build.gradle
@@ -35,8 +35,14 @@ configurations {
validatesPortableRunner
}
+configurations.all {
+ // replace commons logging with the jcl-over-slf4j bridge
+ exclude group: "commons-logging", module: "commons-logging"
+}
+
dependencies {
compile project(path: ":beam-runners-flink_2.11", configuration: "shadow")
+ compile group: "org.slf4j", name: "jcl-over-slf4j", version:
dependencies.create(project.library.java.slf4j_api).getVersion()
validatesPortableRunner project(path: ":beam-runners-flink_2.11",
configuration: "shadowTest")
validatesPortableRunner project(path: ":beam-sdks-java-core", configuration:
"shadowTest")
validatesPortableRunner project(path: ":beam-runners-core-java",
configuration: "shadowTest")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 136335)
Time Spent: 40m (was: 0.5h)
> Flink jobserver logging should be redirected to slf4j
> -----------------------------------------------------
>
> Key: BEAM-5168
> URL: https://issues.apache.org/jira/browse/BEAM-5168
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Affects Versions: 2.6.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently commons-logging goes nowhere, which makes certain issues really
> hard to debug (http client uses it, for example). This can be fixed by using
> the slf4j bridge.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
