[
https://issues.apache.org/jira/browse/BEAM-3310?focusedWorklogId=137391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137391
]
ASF GitHub Bot logged work on BEAM-3310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/18 14:01
Start Date: 23/Aug/18 14:01
Worklog Time Spent: 10m
Work Description: JozoVilcek commented on a change in pull request #4548:
[BEAM-3310] Metrics pusher
URL: https://github.com/apache/beam/pull/4548#discussion_r212320712
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
##########
@@ -120,7 +121,9 @@ public PipelineResult run(Pipeline pipeline) {
if (result instanceof DetachedEnvironment.DetachedJobExecutionResult) {
LOG.info("Pipeline submitted in Detached mode");
- return new FlinkDetachedRunnerResult();
+ FlinkDetachedRunnerResult flinkDetachedRunnerResult = new
FlinkDetachedRunnerResult();
+ // no metricsPusher because metrics are not supported in detached mode
Review comment:
So, do I read this right that detached mode is not going to be supported? Or
there is a push to future to make it available there?
Without it, it is not really agnostic way, as there are run modes which does
not have metrics. Initially I hoped the integration will follow the same
behaviour like if I would implement custom
`org.apache.flink.metrics.reporter.MetricReported`. I do submit my jobs
(streaming) in detached mode. I consider it not helpful to introduce client
process which can die and what then happens to the application on the cluster
and metric pusher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 137391)
Time Spent: 15h 10m (was: 15h)
> Push metrics to a backend in an runner agnostic way
> ---------------------------------------------------
>
> Key: BEAM-3310
> URL: https://issues.apache.org/jira/browse/BEAM-3310
> Project: Beam
> Issue Type: New Feature
> Components: runner-extensions-metrics, sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> The idea is to avoid relying on the runners to provide access to the metrics
> (either at the end of the pipeline or while it runs) because they don't have
> all the same capabilities towards metrics (e.g. spark runner configures sinks
> like csv, graphite or in memory sinks using the spark engine conf). The
> target is to push the metrics in the common runner code so that no matter the
> chosen runner, a user can get his metrics out of beam.
> Here is the link to the discussion thread on the dev ML:
> https://lists.apache.org/thread.html/01a80d62f2df6b84bfa41f05e15fda900178f882877c294fed8be91e@%3Cdev.beam.apache.org%3E
> And the design doc:
> https://s.apache.org/runner_independent_metrics_extraction
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
