[
https://issues.apache.org/jira/browse/BEAM-4378?focusedWorklogId=137986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137986
]
ASF GitHub Bot logged work on BEAM-4378:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/18 21:05
Start Date: 24/Aug/18 21:05
Worklog Time Spent: 10m
Work Description: apilloud closed pull request #5449: [BEAM-4378] Update
JavaDoc for cloud dataflow to support region flag
URL: https://github.com/apache/beam/pull/5449
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
index ddb98f16d1f..2ec9dad6352 100644
---
a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
+++
b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
@@ -104,8 +104,7 @@
* <a
href="https://cloud.google.com/compute/docs/regions-zones/regions-zones";>region</a>
* for creating Dataflow jobs.
*
- * <p>NOTE: The Cloud Dataflow service does not yet honor this setting.
However, once service
- * support is added then users of this SDK will be able to control the
region.
+ * <p>NOTE: The Cloud Dataflow now also supports the region flag.
*/
@Hidden
@Experimental
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 137986)
Time Spent: 20m (was: 10m)
> Update javadoc for set/getRegion in DataflowPipelineOptions.
> ------------------------------------------------------------
>
> Key: BEAM-4378
> URL: https://issues.apache.org/jira/browse/BEAM-4378
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: David Yan
> Assignee: Batkhuyag Batsaikhan
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Dataflow now supports the region flag. We should update the javadoc here:
> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java#L107
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
