[
https://issues.apache.org/jira/browse/BEAM-4864?focusedWorklogId=137988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137988
]
ASF GitHub Bot logged work on BEAM-4864:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/18 21:11
Start Date: 24/Aug/18 21:11
Worklog Time Spent: 10m
Work Description: apilloud closed pull request #6061: [BEAM-4864] Make
run_validatescontainer.sh not quite as hard coded.
URL: https://github.com/apache/beam/pull/6061
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/container/run_validatescontainer.sh
b/sdks/python/container/run_validatescontainer.sh
index e4da78326aa..f23087fddab 100755
--- a/sdks/python/container/run_validatescontainer.sh
+++ b/sdks/python/container/run_validatescontainer.sh
@@ -25,14 +25,16 @@
#
# Execute from the root of the repository:
sdks/python/container/run_validatescontainer.sh
+echo "This script must be executed in the root of beam project. Please set
LOCAL_PATH, GCS_LOCATION, and PROJECT as desired."
+
set -e
set -v
# Where to store integration test outputs.
-GCS_LOCATION=gs://temp-storage-for-end-to-end-tests
+GCS_LOCATION=${GCS_LOCATION:-gs://temp-storage-for-end-to-end-tests}
# Project for the container and integration test
-PROJECT=apache-beam-testing
+PROJECT=${PROJECT:-apache-beam-testing}
# Verify in the root of the repository
test -d sdks/python/container
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 137988)
Time Spent: 1h 40m (was: 1.5h)
> run_validatescontainer.sh in Python sdk has hard-coded bucket of sadness
> ------------------------------------------------------------------------
>
> Key: BEAM-4864
> URL: https://issues.apache.org/jira/browse/BEAM-4864
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-harness
> Reporter: holdenk
> Assignee: holdenk
> Priority: Trivial
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The run_validatescontainer.sh script looks amazing! However I could not
> validate my container, and this made me sad. We can make it configurable and
> then people can validate their container changes more easily :)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
