[ 
https://issues.apache.org/jira/browse/BEAM-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592931#comment-16592931
 ] 

Jozef Vilcek commented on BEAM-5180:
------------------------------------

of put a strong requirement that every path declares a `scheme`. That way a 
default_scheme could be dropped and never guessed
[https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java#L443]

windows paths will needs to be `file:///c:/something/in/here`

But my sight is limited so this might not feasible for some reasons I do not 
foresee. Just an idea

> Broken FileResultCoder via parseSchema change
> ---------------------------------------------
>
>                 Key: BEAM-5180
>                 URL: https://issues.apache.org/jira/browse/BEAM-5180
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.6.0
>            Reporter: Jozef Vilcek
>            Assignee: Ankur Goenka
>            Priority: Blocker
>             Fix For: 2.7.0
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Recently this commit
> [https://github.com/apache/beam/commit/3fff58c21f94415f3397e185377e36d3df662384]
> introduced more strict schema parsing which is breaking the contract between 
> _FileResultCoder_ and _FileSystems.matchNewResource()_.
> Coder takes _ResourceId_ and serialize it via `_toString_` methods and then 
> relies on filesystem being able to parse it back again. Having strict 
> _scheme://_ breaks this at least for Hadoop filesystem which use _URI_ for 
> _ResourceId_ and produce _toString()_ in form of `_hdfs:/some/path_`
> I guess the _ResourceIdCoder_ is suffering the same problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to