[
https://issues.apache.org/jira/browse/BEAM-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593447#comment-16593447
]
Jozef Vilcek commented on BEAM-4861:
------------------------------------
For unsuccessful operation, I would throw exception as well. In practice, this
is what is mostly done around the native HDFS boolean methods by helpers. Fail
and investigate later what was wrong.
For rename, create directories where necessary sounds good. Plus with allowing
overwrites, behaviour would be consistent with what I observe on "normal file
create" operations. Allow overwrite is maybe allowed for cases or restarting
jobs form snapshots which can lead to reprocessing and recreating same outputs
again? Not sure.
> Hadoop Filesystem silently fails
> --------------------------------
>
> Key: BEAM-4861
> URL: https://issues.apache.org/jira/browse/BEAM-4861
> Project: Beam
> Issue Type: Bug
> Components: io-java-hadoop
> Reporter: Jozef Vilcek
> Assignee: Chamikara Jayalath
> Priority: Major
>
> Hi,
> beam Filesystem operations copy, rename and delete are void in SDK. Hadoop
> native filesystem operations are not and returns void. Current implementation
> in Beam ignores the result and pass as long as exception is not thrown.
> I got burned by this when using 'rename' to do a 'move' operation on HDFS. If
> target directory does not exists, operations returns false and do not touch
> the file.
> [https://github.com/apache/beam/blob/master/sdks/java/io/hadoop-file-system/src/main/java/org/apache/beam/sdk/io/hdfs/HadoopFileSystem.java#L148]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
