[
https://issues.apache.org/jira/browse/BEAM-5255?focusedWorklogId=139300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-139300
]
ASF GitHub Bot logged work on BEAM-5255:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/18 15:57
Start Date: 29/Aug/18 15:57
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #6293: [BEAM-5255] Fix
over-aggressive division futurization in benchmarks.
URL: https://github.com/apache/beam/pull/6293#issuecomment-417005802
LGTM thank you. See also: https://issues.apache.org/jira/browse/BEAM-4858.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 139300)
Time Spent: 0.5h (was: 20m)
> Fix over-aggressive division futurization.
> ------------------------------------------
>
> Key: BEAM-5255
> URL: https://issues.apache.org/jira/browse/BEAM-5255
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.6.0
> Reporter: Robert Bradshaw
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When converting from Python 2 to Python 3, `a / b` becomes `a // b` only for
> ints, but it is incorrect to do this substitution for floating point
> division.
>
> I noticed this change in the microbenchmarks, but we should do an audit to
> make sure we haven't broken things elsewhere.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
