[
https://issues.apache.org/jira/browse/BEAM-4495?focusedWorklogId=139409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-139409
]
ASF GitHub Bot logged work on BEAM-4495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/18 19:55
Start Date: 29/Aug/18 19:55
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #6282:
[BEAM-4495] Website pre-commit job
URL: https://github.com/apache/beam/pull/6282#discussion_r213812204
##########
File path: website/Rakefile
##########
@@ -3,16 +3,18 @@ require 'html-proofer'
require 'etc'
task :test do
- FileUtils.rm_rf('./.testcontent')
- sh "bundle exec jekyll build --config _config.yml,_config_test.yml"
- HTMLProofer.check_directory("./.testcontent", {
+ HTMLProofer.check_directory("./content", {
:typhoeus => {
:timeout => 60,
:connecttimeout => 40 },
:allow_hash_href => true,
:check_html => true,
:file_ignore => [/javadoc/, /v2/, /pydoc/],
:url_ignore => [
+ # Javadocs and Pydocs are only available on asf-site branch
+ /documentation\/sdks\/javadoc/,
+ /documentation\/sdks\/pydoc/,
Review comment:
Does this mean that we will need to check in the generated javadocs here (in
the asf-site branch)?
If so:
* We'll need to update the [release manager
scripts](https://github.com/apache/beam/blob/master/release/src/main/scripts/build_release_candidate.sh).
Maybe create a JIRA to track that?
* Won't this explode the size of the repo? I know this has been discussed
by others, and we can leave it for later, but how feasible is to avoid checking
in generated files? (now or in the future)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 139409)
Time Spent: 5h 40m (was: 5.5h)
> Create website pre-commits for apache/beam repository
> -----------------------------------------------------
>
> Key: BEAM-4495
> URL: https://issues.apache.org/jira/browse/BEAM-4495
> Project: Beam
> Issue Type: Sub-task
> Components: testing, website
> Reporter: Scott Wegner
> Assignee: Udi Meiri
> Priority: Major
> Labels: beam-site-automation-reliability
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
