[
https://issues.apache.org/jira/browse/BEAM-5239?focusedWorklogId=139675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-139675
]
ASF GitHub Bot logged work on BEAM-5239:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/18 13:09
Start Date: 30/Aug/18 13:09
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6278:
[BEAM-5239] Enable to configure latencyTrackingInterval
URL: https://github.com/apache/beam/pull/6278#discussion_r214023347
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -171,4 +176,12 @@ public static StreamExecutionEnvironment
createStreamExecutionEnvironment(
return flinkStreamEnv;
}
+
+ private static void applyLatencyTrackingInterval(
+ ExecutionConfig config, FlinkPipelineOptions options) {
+ long latencyTrackingInterval = options.getLatencyTrackingInterval();
+ if (latencyTrackingInterval >= 0) {
Review comment:
The default is now 0, so it gets disabled by default now. I agree with
Aljoscha that the check could be removed entirely. The problem is, if you pass
in negative numbers, they will simply be ignored and latency tracking will
still be enabled...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 139675)
Time Spent: 2h 20m (was: 2h 10m)
> Allow configure latencyTrackingInterval
> ---------------------------------------
>
> Key: BEAM-5239
> URL: https://issues.apache.org/jira/browse/BEAM-5239
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Affects Versions: 2.6.0
> Reporter: Jozef Vilcek
> Assignee: Aljoscha Krettek
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Because of FLINK-10226, we need to be able to set
> latencyTrackingConfiguration for flink via FlinkPipelineOptions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
